fix(tests): disambiguate EtcdFilterType.none in EtcdQueryBuilderTests#1718
Merged
datlechin merged 2 commits intoJun 18, 2026
Merged
Conversation
`parsed?.filterType == .none` resolves `.none` to `Optional<EtcdFilterType>.none` under the current Swift toolchain, which (a) trips the warnings-as-errors build of the test target and (b) compares filterType against nil rather than the intended `EtcdFilterType.none` case. Since each call site already asserts `parsed != nil`, spell out `EtcdFilterType.none` so the assertion checks the enum case it means to.
datlechin
approved these changes
Jun 18, 2026
Contributor
Author
|
Thanks for reviewing and merging, @datlechin. Disambiguating EtcdFilterType.none gets the query-builder test building under the current Swift toolchain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Etcd query-builder test target fails to build under the current Swift toolchain:
parsed?.filterType == .noneresolves.nonetoOptional<EtcdFilterType>.nonerather thanEtcdFilterType.none. Under warnings-as-errors that breaks the wholemacOS App Teststarget, and semantically the comparison checkedfilterTypeagainst nil instead of the.noneenum case (each call site already assertsparsed != nil).This spells out
EtcdFilterType.noneat the four call sites so the assertions check the intended enum case and the target builds. No production code changed.